rdblue commented on a change in pull request #4162:
URL: https://github.com/apache/iceberg/pull/4162#discussion_r812201336
##########
File path:
core/src/main/java/org/apache/iceberg/actions/BaseRewriteDataFilesAction.java
##########
@@ -300,6 +302,10 @@ void doReplace(Iterable<DataFile> deletedDataFiles,
Iterable<DataFile> addedData
private boolean isPartialFileScan(CombinedScanTask task) {
if (task.files().size() == 1) {
FileScanTask fileScanTask = task.files().iterator().next();
+ if (fileScanTask.file().format() == FileFormat.PARQUET) {
+ // in parquet format, there is an initial offset of 4 bytes
+ return fileScanTask.file().fileSizeInBytes() != (fileScanTask.length()
+ PARQUET_MAGIC_BYTES);
+ }
Review comment:
That wouldn't be a problem with Parquet. The format will first read the
file footer and then find all row groups that are assigned to it via the split
range, and then seek directly to the start of those row groups. This wouldn't
be a problem at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
