rdblue commented on a change in pull request #4081:
URL: https://github.com/apache/iceberg/pull/4081#discussion_r810542515
##########
File path: python/src/iceberg/io/base.py
##########
@@ -76,7 +76,15 @@ def close(self) -> None:
class InputFile(ABC):
- """A base class for InputFile implementations"""
+ """A base class for InputFile implementations
+
+ Args:
+ location(str): A URI or a path to a local file
+
+ Attributes:
+ location(str): The URI or path to a local file for an InputFile
instance
+ exists(bool): Whether the file exists or not
+ """
Review comment:
I just realized that we're missing a method for both `InputFile` and
`OutputFile`: `close`! It's not needed to read or write, but it's really
important!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
