rdblue commented on a change in pull request #4037: URL: https://github.com/apache/iceberg/pull/4037#discussion_r810545920
########## File path: core/src/main/java/org/apache/iceberg/rest/requests/UpdateNamespacePropertiesRequest.java ########## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.rest.requests; + +import java.util.Collection; +import java.util.List; +import java.util.Map; +import java.util.Objects; +import org.apache.iceberg.relocated.com.google.common.base.MoreObjects; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableList; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableSet; +import org.apache.iceberg.relocated.com.google.common.collect.Maps; + +/** + * A REST request to set and/or remove properties on a namespace. + */ +public class UpdateNamespacePropertiesRequest { + + private List<String> removals; + private Map<String, String> updates; + + public UpdateNamespacePropertiesRequest() { + // Required for Jackson deserialization. + } + + private UpdateNamespacePropertiesRequest(List<String> removals, Map<String, String> updates) { + this.removals = removals; + this.updates = updates; + validate(); + } + + UpdateNamespacePropertiesRequest validate() { + Preconditions.checkArgument(removals != null || updates != null, + "Invalid value for update namespace properties request: at least one of updates and removals must be non-null"); + return this; + } + + public List<String> removals() { + return removals == null ? ImmutableList.of() : removals; + } + + public Map<String, String> updates() { + return updates == null ? ImmutableMap.of() : updates; + } + + @Override + public String toString() { + return MoreObjects.toStringHelper(this) + .add("removals", removals) + .add("updates", updates) + .toString(); + } + + public static Builder builder() { + return new Builder(); + } + + public static class Builder { + private final ImmutableSet.Builder<String> removalsBuilder = ImmutableSet.builder(); + private final ImmutableMap.Builder<String, String> updatesBuilder = ImmutableMap.builder(); + + private Builder() { + } + + public Builder remove(String removal) { + Preconditions.checkNotNull(removal, + "Invalid property to remove: null"); + removalsBuilder.add(removal); + return this; + } + + public Builder removeAll(Collection<String> removals) { + Preconditions.checkNotNull(removals, + "Invalid list of properties to remove: null"); + Preconditions.checkArgument(!removals.contains(null), + "Invalid value in list of properties to remove: null"); + removalsBuilder.addAll(removals); + return this; + } + + public Builder update(String key, String value) { + Preconditions.checkNotNull(key, + "Invalid property to update: null"); + Preconditions.checkNotNull(value, + "Invalid value to update for key [%s]: null. Use remove instead", key); + updatesBuilder.put(key, value); + return this; + } + + public Builder updateAll(Map<String, String> updates) { + Preconditions.checkNotNull(updates, + "Invalid collection of properties to update: null"); + Preconditions.checkArgument(!updates.containsKey(null), + "Invalid property in collection of properties to update: null"); Review comment: Same here. I'd probably say "Invalid property to update: null" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
