rdblue commented on a change in pull request #4037: URL: https://github.com/apache/iceberg/pull/4037#discussion_r810546926
########## File path: core/src/main/java/org/apache/iceberg/rest/responses/ListNamespacesResponse.java ########## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + + +package org.apache.iceberg.rest.responses; + +import java.util.Collection; +import java.util.List; +import org.apache.iceberg.catalog.Namespace; +import org.apache.iceberg.relocated.com.google.common.base.MoreObjects; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableList; + +public class ListNamespacesResponse { + + private List<Namespace> namespaces; + + public ListNamespacesResponse() { + // Required for Jackson deserialization + } + + private ListNamespacesResponse(List<Namespace> namespaces) { + this.namespaces = namespaces; + validate(); + } + + ListNamespacesResponse validate() { + Preconditions.checkArgument(namespaces != null, + "Cannot create a response to a list namespaces request without a non-null list of namespaces"); + return this; + } + + + public List<Namespace> namespaces() { + return namespaces != null ? namespaces : ImmutableList.of(); + } + + @Override + public String toString() { + return MoreObjects.toStringHelper(this) + .add("namespaces", namespaces()) + .toString(); + } + + public static Builder builder() { + return new Builder(); + } + + static class Builder { + private final ImmutableList.Builder<Namespace> namespaces = ImmutableList.builder(); + + private Builder() { + } + + public Builder add(Namespace toAdd) { + Preconditions.checkNotNull(toAdd, + "Invalid namespace to list: null"); Review comment: `Invalid namespace: null` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
