rdblue commented on a change in pull request #4154:
URL: https://github.com/apache/iceberg/pull/4154#discussion_r812474737
##########
File path: api/src/main/java/org/apache/iceberg/types/ReassignIds.java
##########
@@ -43,6 +45,17 @@ public Type schema(Schema schema, Supplier<Type> future) {
}
}
+ private int id(Types.StructType sourceStruct, String name) {
+ if (sourceStruct != null) {
+ Types.NestedField sourceField = sourceStruct.field(name);
+ if (sourceField != null) {
+ return sourceField.fieldId();
+ }
+ }
+
+ return assignId.get();
Review comment:
Yeah, this is from a previous version where I was going to throw an
exception from `assignId`. I'll fix it up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
