jackye1995 edited a comment on pull request #4102: URL: https://github.com/apache/iceberg/pull/4102#issuecomment-1048562878
@rdblue I have been thinking about this during the night, I think it's better to move this class to the `org.apache.iceberg.aws.dynamodb` module instead of keeping it as is. With the Glue optimistic locking change, I don't think any new user will use `org.apache.iceberg.aws.glue.DynamoLockManager`. The lock manager will only be for locking the file system of `HadoopCatalog` commits. It will be very confusing for those users to reference a DynamoDB lock in `glue` package, and it will be a lot of context for those users to understand. So thinking from those users' perspective, it is better for us to provide a clean package path for the DynamoDB lock manager. For existing users of `org.apache.iceberg.aws.glue.DynamoLockManager`, we are able to keep their experience using this and also see the warning message. I think this is the best path forward. Please let me know if you object, otherwise I will merge the PR after updating the warning message to be more concrete. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
