kbendick commented on a change in pull request #4210:
URL: https://github.com/apache/iceberg/pull/4210#discussion_r815032777



##########
File path: .github/workflows/flink-ci.yml
##########
@@ -20,25 +20,8 @@
 name: "Flink CI"
 on:
   push:
-    paths-ignore:
-    - '.github/workflows/python-ci.yml'
-    - '.github/workflows/spark-ci.yml'
-    - '.github/workflows/hive-ci.yml'
-    - '.github/workflows/cancel-duplicate-workflow-runs.yml'
-    - '.gitignore'
-    - 'dev/**'
-    - 'mr/**'
-    - 'hive3/**'
-    - 'hive3-orc-bundle/**'
-    - 'hive-runtime/**'
-    - 'spark/**'
-    - 'pig/**'
-    - 'python/**'
-    - 'python_legacy/**'
-    - 'docs/**'
-    - '.gitattributes'
-    - 'README.md'
-    - 'CONTRIBUTING.md'
+    branches:
+    - 'master'

Review comment:
       For now, I just added `'**'` to catch all, as that's the only thing we 
use tags for presently anyway.
   
   The tags from the examples use two asterisks, so I went with that: 
https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#running-your-workflow-only-when-a-push-of-specific-tags-occurs
   
   I can try merging this into my own fork and then pushing a tag to ensure it 
works or we can just merge it and then check in the fork (less work). I'm open 
either way.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to