amogh-jahagirdar commented on a change in pull request #4071:
URL: https://github.com/apache/iceberg/pull/4071#discussion_r816385131
##########
File path: core/src/main/java/org/apache/iceberg/MetadataUpdate.java
##########
@@ -165,6 +165,24 @@ public String name() {
}
}
+ class CreateSnapshotRef implements MetadataUpdate {
Review comment:
A rename/update to a ref will be an ordered Remove + Create. Seems a bit
inefficient in the sense of how many updates are needed to encapsulate a single
update, but seems like the intention of this metadata update is to give an
ordered, immutable series of operations to build metadata state.
##########
File path: core/src/main/java/org/apache/iceberg/SnapshotReferenceChanges.java
##########
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iceberg;
+
+import java.util.Map;
+import java.util.Set;
+
+class SnapshotReferenceChanges {
Review comment:
This seemed like the best way to encapsulate the "delta" of reference
changes that could occur.
##########
File path: core/src/main/java/org/apache/iceberg/TableMetadata.java
##########
@@ -949,6 +957,26 @@ public Builder setBranchSnapshot(long snapshotId, String
branch) {
return this;
}
+ public Builder createSnapshotRef(String name, SnapshotRef ref) {
Review comment:
In the builder layer would we want a separate createBranch/createTag? We
do that for remove, but for creating it seems redundant. What would
createBranch do differently than createTag?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
