amogh-jahagirdar commented on a change in pull request #4071:
URL: https://github.com/apache/iceberg/pull/4071#discussion_r816386006
##########
File path: core/src/main/java/org/apache/iceberg/TableMetadata.java
##########
@@ -949,6 +957,26 @@ public Builder setBranchSnapshot(long snapshotId, String
branch) {
return this;
}
+ public Builder createSnapshotRef(String name, SnapshotRef ref) {
Review comment:
In the builder layer would we want a separate createBranch/createTag? We
do that for remove, but for creating it seems redundant. What would
createBranch do differently than createTag beyond some validation that the ref
is a branch or a tag?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
