jackye1995 commented on a change in pull request #4254:
URL: https://github.com/apache/iceberg/pull/4254#discussion_r818233756
##########
File path: aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java
##########
@@ -43,14 +45,15 @@
*/
public class S3FileIO implements FileIO {
private static final Logger LOG = LoggerFactory.getLogger(S3FileIO.class);
- private static final String DEFAULT_METRICS_IMPL =
"org.apache.iceberg.hadoop.HadoopMetricsContext";
private SerializableSupplier<S3Client> s3;
private AwsProperties awsProperties;
private transient S3Client client;
private MetricsContext metrics = MetricsContext.nullMetrics();
private final AtomicBoolean isResourceClosed = new AtomicBoolean(false);
+ private static final String IO_METRICS_SCHEME_S3 = "s3";
Review comment:
class variables should be placed before instance variables
##########
File path: aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java
##########
@@ -43,14 +45,15 @@
*/
public class S3FileIO implements FileIO {
private static final Logger LOG = LoggerFactory.getLogger(S3FileIO.class);
- private static final String DEFAULT_METRICS_IMPL =
"org.apache.iceberg.hadoop.HadoopMetricsContext";
private SerializableSupplier<S3Client> s3;
private AwsProperties awsProperties;
private transient S3Client client;
private MetricsContext metrics = MetricsContext.nullMetrics();
private final AtomicBoolean isResourceClosed = new AtomicBoolean(false);
+ private static final String IO_METRICS_SCHEME_S3 = "s3";
Review comment:
nit: class variables should be placed before instance variables
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
