jackye1995 commented on a change in pull request #4254:
URL: https://github.com/apache/iceberg/pull/4254#discussion_r818155551
##########
File path: core/src/main/java/org/apache/iceberg/CatalogUtil.java
##########
@@ -275,6 +276,25 @@ public static FileIO loadFileIO(
return fileIO;
}
+ public static MetricsContext loadFileIOMetricsContext(
+ String impl,
+ Map<String, String> properties) {
Review comment:
this should also have the `Object hadoopConf` in the parameter like
`loadFileIO`, we will pass in `null` in S3FileIO but other implementations
might leverage this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
