openinx commented on a change in pull request #3784:
URL: https://github.com/apache/iceberg/pull/3784#discussion_r819238427
##########
File path: orc/src/main/java/org/apache/iceberg/orc/OrcFileAppender.java
##########
@@ -153,4 +176,10 @@ private static Writer newOrcWriter(OutputFile file,
createWriterFunc) {
return (OrcRowWriter<D>) createWriterFunc.apply(schema, orcSchema);
}
+
+ private TreeWriter treeWriterHiddenInORC() {
+ DynFields.BoundField<TreeWriter> treeWriterFiled =
+ DynFields.builder().hiddenImpl(writer.getClass(),
"treeWriter").build(writer);
Review comment:
Another thing is: the `treeWriter` is a private member in `writer`'s
underlying implementation `WriterImpl`. Is is possible to create a new pull
request in [apache orc ](https://github.com/apache/orc) project to expose the
`TreeWriter` or `estimateMemory()` from `org.apache.orc.Writer` so that we can
get rid of this in the further iceberg release ?
CC @rdblue @dongjoon-hyun @marton-bod @pvary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
