openinx commented on a change in pull request #3784:
URL: https://github.com/apache/iceberg/pull/3784#discussion_r830954859
##########
File path: orc/src/main/java/org/apache/iceberg/orc/ORCSchemaUtil.java
##########
@@ -103,42 +104,57 @@ public TypeDescription type() {
private ORCSchemaUtil() {
}
- public static TypeDescription convert(Schema schema) {
+ public static TypeDescription convertSchema2TypeDesc(Schema schema) {
+ return convertSchema2TypeDescWithLength(schema).first();
+ }
+
+ public static Pair<TypeDescription, Integer>
convertSchema2TypeDescWithLength(Schema schema) {
Review comment:
Why not just customize a `OrcSchemaVisitor` to calculate the estimated
avg row size to decouple with the schema convertion logic ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
