rdblue commented on a change in pull request #3998:
URL: https://github.com/apache/iceberg/pull/3998#discussion_r819772923
##########
File path:
flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/sink/FlinkSink.java
##########
@@ -174,6 +175,15 @@ public Builder table(Table newTable) {
return this;
}
+ /**
+ * Set the write properties for Flink sink. Write properties (with the
same keys) defined in table properties
+ * will be overwritten by properties provided here.
+ */
+ public Builder properties(Map<String, String> newProps) {
Review comment:
Other APIs use `set` for individual key/value properties and `setAll`
for a map of properties. Can you update this to `set` or `setProperties`? It
isn't clear what `properties` does.
In the `Parquet` write builder, for example, we have these methods:
```java
public WriteBuilder set(String property, String value) {
config.put(property, value);
return this;
}
public WriteBuilder setAll(Map<String, String> properties) {
config.putAll(properties);
return this;
}
```
This should also add properties, not replace previous properties set by this
method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
