rdblue commented on a change in pull request #3998:
URL: https://github.com/apache/iceberg/pull/3998#discussion_r819774784
##########
File path:
flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/sink/FlinkSink.java
##########
@@ -515,14 +549,21 @@ static RowType toFlinkRowType(Schema schema, TableSchema
requestedSchema) {
RowType flinkRowType,
List<Integer>
equalityFieldIds,
boolean upsert) {
+ return createStreamWriter(table, table.properties(), flinkRowType,
equalityFieldIds, upsert);
Review comment:
Is this still called? Why preserve this method if it isn't public?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
