kbendick commented on a change in pull request #4267:
URL: https://github.com/apache/iceberg/pull/4267#discussion_r819944075
##########
File path: gcp/src/test/java/org/apache/iceberg/gcp/gcs/GCSOutputStreamTest.java
##########
@@ -57,14 +58,16 @@ public void testWrite() {
@Test
public void testMultipleClose() throws IOException {
- GCSOutputStream stream = new GCSOutputStream(storage, randomBlobId(),
properties);
+ GCSOutputStream stream = new GCSOutputStream(storage, randomBlobId(),
properties, MetricsContext
+ .nullMetrics());
Review comment:
Nit: Avoid breaking up a chained call as an argument across two lines.
In this case I would move all arguments to the next line.
But having `MetricsContext` and then `.nullMetrics()` on the next line is
confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
