rajarshisarkar commented on a change in pull request #4267:
URL: https://github.com/apache/iceberg/pull/4267#discussion_r822479020
##########
File path: gcp/src/main/java/org/apache/iceberg/gcp/gcs/GCSInputFile.java
##########
@@ -24,14 +24,17 @@
import org.apache.iceberg.gcp.GCPProperties;
import org.apache.iceberg.io.InputFile;
import org.apache.iceberg.io.SeekableInputStream;
+import org.apache.iceberg.metrics.MetricsContext;
public class GCSInputFile extends BaseGCSFile implements InputFile {
- public static GCSInputFile fromLocation(String location, Storage storage,
GCPProperties gcpProperties) {
- return new GCSInputFile(storage, BlobId.fromGsUtilUri(location),
gcpProperties);
+
+ public static GCSInputFile fromLocation(String location, Storage storage,
Review comment:
Thanks, for the feedback. I have made the class and method
package-private.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
