samredai commented on a change in pull request #4262:
URL: https://github.com/apache/iceberg/pull/4262#discussion_r821096058
##########
File path: python/.coveragerc
##########
@@ -20,5 +20,5 @@ skip_empty = true
[run]
omit =
- # omit this single file
- src/iceberg/literals.py
+ src/iceberg/expression/literals.py
Review comment:
re: coverage--If all of this logic in the base classes are not used
anywhere, we shouldn't need them at all right? I think defining these as ABC
classes will allow us to provide more clarity by clearly decorating what's an
`@abstractmethod` and leaving the function body empty (just a doc string).
That's a clear signal to coverage as well that there's nothing to cover. Any
concrete methods in an ABC class would be there because they're used somewhere
which means they can be covered in tests. Similar to what's in
[io/base.py](https://github.com/apache/iceberg/blob/master/python/src/iceberg/io/base.py).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
