rdblue commented on a change in pull request #4254:
URL: https://github.com/apache/iceberg/pull/4254#discussion_r821157522
##########
File path: api/src/main/java/org/apache/iceberg/metrics/MetricsContext.java
##########
@@ -29,6 +29,21 @@
* like thread safety and serialization.
*/
public interface MetricsContext extends Serializable {
+ MetricsContext NULL_METRICS = new MetricsContext() {
Review comment:
Then we should move it outside of the interface? No need to have both
NULL_METRICS and `nullMetrics()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
