rdblue commented on a change in pull request #4254:
URL: https://github.com/apache/iceberg/pull/4254#discussion_r821224853
##########
File path: core/src/main/java/org/apache/iceberg/CatalogProperties.java
##########
@@ -81,4 +81,8 @@ private CatalogProperties() {
public static final String APP_ID = "app-id";
public static final String USER = "user";
+ public static final String IO_METRICS_IMPL = "io.metrics-impl";
+ public static final String IO_METRICS_IMPL_DEFAULT =
"org.apache.iceberg.hadoop.HadoopMetricsContext";
+ public static final String IO_METRICS_NAMESPACE = "io.metrics.namespace";
Review comment:
I think the best solution here is to not define a public property for
"namespace". I think the IO classes should just pass a "scheme" option into the
metrics class. No need to define a contract or to try to make this generic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
