RussellSpitzer commented on a change in pull request #4301:
URL: https://github.com/apache/iceberg/pull/4301#discussion_r823164110
##########
File path: format/spec.md
##########
@@ -158,7 +158,7 @@ For the representations of these types in Avro, ORC, and
Parquet file formats, s
#### Nested Types
-A **`struct`** is a tuple of typed values. Each field in the tuple is named
and has an integer id that is unique in the table schema. Each field can be
either optional or required, meaning that values can (or cannot) be null.
Fields may be any type. Fields may have an optional comment or doc string.
+A **`struct`** is a tuple of typed values. Each field in the tuple is named
and has an integer id that is unique in the table schema. Each field can be
either optional or required, meaning that values can (or cannot) be null.
Fields may be any type. Fields may have an optional comment or doc string.
Fields can also have a default value (see below).
Review comment:
Do we need to specify that these default values are only retroactive? Ie
we still do not allow skipping a required column just because the said column
has a default? I haven't read the SQL spec on this or other system's usage, but
I assume we want to align on that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
