rdblue commented on a change in pull request #4301:
URL: https://github.com/apache/iceberg/pull/4301#discussion_r823189277
##########
File path: format/spec.md
##########
@@ -158,7 +158,7 @@ For the representations of these types in Avro, ORC, and
Parquet file formats, s
#### Nested Types
-A **`struct`** is a tuple of typed values. Each field in the tuple is named
and has an integer id that is unique in the table schema. Each field can be
either optional or required, meaning that values can (or cannot) be null.
Fields may be any type. Fields may have an optional comment or doc string.
+A **`struct`** is a tuple of typed values. Each field in the tuple is named
and has an integer id that is unique in the table schema. Each field can be
either optional or required, meaning that values can (or cannot) be null.
Fields may be any type. Fields may have an optional comment or doc string.
Fields can also have a default value (see below).
Review comment:
@RussellSpitzer are you saying that all columns are required at write
time? It sounds like that's the case. Just because there's a default value
doesn't mean you can skip writing a column to a Parquet file. They must be
present.
I think that's a good thing to call out! But maybe not here. I think the
section on default values is the right place for details like that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
