rdblue commented on a change in pull request #4071: URL: https://github.com/apache/iceberg/pull/4071#discussion_r825190673
########## File path: core/src/main/java/org/apache/iceberg/ManageSnapshotReferenceOperation.java ########## @@ -0,0 +1,183 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg; + +import java.util.Map; +import java.util.Set; +import org.apache.iceberg.exceptions.CommitFailedException; +import org.apache.iceberg.exceptions.ValidationException; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; +import org.apache.iceberg.relocated.com.google.common.collect.Maps; +import org.apache.iceberg.relocated.com.google.common.collect.Sets; +import org.apache.iceberg.util.Tasks; + +import static org.apache.iceberg.TableProperties.COMMIT_MAX_RETRY_WAIT_MS; +import static org.apache.iceberg.TableProperties.COMMIT_MAX_RETRY_WAIT_MS_DEFAULT; +import static org.apache.iceberg.TableProperties.COMMIT_MIN_RETRY_WAIT_MS; +import static org.apache.iceberg.TableProperties.COMMIT_MIN_RETRY_WAIT_MS_DEFAULT; +import static org.apache.iceberg.TableProperties.COMMIT_NUM_RETRIES; +import static org.apache.iceberg.TableProperties.COMMIT_NUM_RETRIES_DEFAULT; +import static org.apache.iceberg.TableProperties.COMMIT_TOTAL_RETRY_TIME_MS; +import static org.apache.iceberg.TableProperties.COMMIT_TOTAL_RETRY_TIME_MS_DEFAULT; + +class ManageSnapshotReferenceOperation implements PendingUpdate<SnapshotReferenceChanges> { + + private final TableOperations ops; + private TableMetadata base; + private final Map<String, SnapshotRef> refsToAdd; + private final Set<String> tagsToRemove; + private final Set<String> branchesToRemove; + + ManageSnapshotReferenceOperation(TableOperations ops) { + this.ops = ops; + this.base = ops.current(); + this.refsToAdd = Maps.newHashMap(); + this.tagsToRemove = Sets.newHashSet(); + this.branchesToRemove = Sets.newHashSet(); + } + + @Override + public SnapshotReferenceChanges apply() { + internalApply(); + return new SnapshotReferenceChanges(branchesToRemove, tagsToRemove, refsToAdd); + } + + @Override + public void commit() { + Tasks.foreach(ops) + .retry(base.propertyAsInt(COMMIT_NUM_RETRIES, COMMIT_NUM_RETRIES_DEFAULT)) + .exponentialBackoff( + base.propertyAsInt(COMMIT_MIN_RETRY_WAIT_MS, COMMIT_MIN_RETRY_WAIT_MS_DEFAULT), + base.propertyAsInt(COMMIT_MAX_RETRY_WAIT_MS, COMMIT_MAX_RETRY_WAIT_MS_DEFAULT), + base.propertyAsInt(COMMIT_TOTAL_RETRY_TIME_MS, COMMIT_TOTAL_RETRY_TIME_MS_DEFAULT), + 2.0 /* exponential */) + .onlyRetryOn(CommitFailedException.class) + .run(taskOps -> { + TableMetadata updated = internalApply(); + if (updated.changes().isEmpty()) { + return; + } + taskOps.commit(base, updated); + }); + } + + public ManageSnapshotReferenceOperation createBranch( + String name, + long snapshotId, + Long maxRefAgeMs, + Integer minSnapshotsToKeep, + Long maxSnapshotAgeMs) { + + Preconditions.checkNotNull(name, "Branch name cannot be null"); + SnapshotRef branch = SnapshotRef.branchBuilder(snapshotId) + .maxSnapshotAgeMs(maxSnapshotAgeMs) + .maxRefAgeMs(maxRefAgeMs) + .minSnapshotsToKeep(minSnapshotsToKeep) + .build(); + + refsToAdd.put(name, branch); + return this; + } + + public ManageSnapshotReferenceOperation createTag( + String name, + long snapshotId, + Long maxRefAgeMs) { + + Preconditions.checkNotNull(name, "Tag name cannot be null"); + SnapshotRef tag = SnapshotRef.tagBuilder(snapshotId) + .maxRefAgeMs(maxRefAgeMs) + .build(); + refsToAdd.put(name, tag); + return this; + } + + public ManageSnapshotReferenceOperation removeBranch(String name) { + Preconditions.checkNotNull(name, "Branch name cannot be null"); + branchesToRemove.add(name); + return this; + } + + public ManageSnapshotReferenceOperation removeTag(String name) { + Preconditions.checkNotNull(name, "Tag name cannot be null"); + tagsToRemove.add(name); + return this; + } + + public ManageSnapshotReferenceOperation renameBranch(String name, String newName) { + Preconditions.checkNotNull(name, "Tag name cannot be null"); + Preconditions.checkNotNull(newName, "Tag name cannot be null"); + SnapshotRef ref = base.refs().get(name); + ValidationException.check(ref != null, "No such branch with name %s", name); + ValidationException.check(ref.isBranch(), "%s is a tag not a branch", name); + tagsToRemove.add(name); + refsToAdd.put(newName, ref); + return this; + } + + public ManageSnapshotReferenceOperation setBranchRetention( + String name, + int minSnapshotsToKeep, + Long maxRefAgeMs, + Long maxSnapshotAgeMs) { Review comment: Iceberg doesn't use one line per argument. Can you reformat these cases? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
