rdblue commented on a change in pull request #4071:
URL: https://github.com/apache/iceberg/pull/4071#discussion_r825193204
##########
File path: core/src/main/java/org/apache/iceberg/MetadataUpdate.java
##########
@@ -165,6 +165,24 @@ public String name() {
}
}
+ class CreateSnapshotRef implements MetadataUpdate {
Review comment:
I see the rationale for this, but I don't think there is a reason to
have separate `CreateSnapshotRef` and `SetSnapshotRef` classes. I think we
should just add the ref metadata to the `SetSnapshotRef` class.
`SetSnapshotRef` was intended to be an idempotent update that creates or
updates a ref.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
