RussellSpitzer commented on a change in pull request #3676:
URL: https://github.com/apache/iceberg/pull/3676#discussion_r826087288
##########
File path: core/src/main/java/org/apache/iceberg/actions/BinPackStrategy.java
##########
@@ -155,9 +155,12 @@ public RewriteStrategy options(Map<String, String>
options) {
public Iterable<List<FileScanTask>> planFileGroups(Iterable<FileScanTask>
dataFiles) {
ListPacker<FileScanTask> packer = new
BinPacking.ListPacker<>(maxGroupSize, 1, false);
List<List<FileScanTask>> potentialGroups = packer.pack(dataFiles,
FileScanTask::length);
+
return potentialGroups.stream().filter(group ->
- group.size() >= minInputFiles || sizeOfInputFiles(group) >
targetFileSize ||
- group.stream().anyMatch(this::taskHasTooManyDeletes)
+ (group.size() >= minInputFiles && group.size() > 1) ||
+ sizeOfInputFiles(group) > targetFileSize ||
Review comment:
I think this would be easier to understand if was > maxFileSize although
realistically at this point in the code it could only get to this point if the
size was larger than maxFileSize.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
