RussellSpitzer commented on a change in pull request #3676:
URL: https://github.com/apache/iceberg/pull/3676#discussion_r826319197
##########
File path:
core/src/test/java/org/apache/iceberg/actions/TestBinPackStrategy.java
##########
@@ -187,10 +212,10 @@ public void testGroupingWithDeletes() {
@Test
public void testMaxGroupSize() {
RewriteStrategy strategy = defaultBinPack().options(ImmutableMap.of(
- RewriteDataFiles.MAX_FILE_GROUP_SIZE_BYTES, Long.toString(1000 * MB)
+ RewriteDataFiles.MAX_FILE_GROUP_SIZE_BYTES, Long.toString(1300 * MB)
Review comment:
Hmmm this makes me think that maybe I was wrong to change that
parameter. I think we want groups in in any of the following conditions
1. Any group that has more than min_input_files
2. Any group which will successfully write a brand new file closer to target
file size
3. Any group which contains a file larger than max_target file size
4. Any group which has more deletes than the dele threshold
I think 2 is sizeOfInput(files) > target file size and numFiles > 1
I think 3 is sizeOfInput(files) > maxTargetFileSize
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
