singhpk234 commented on a change in pull request #3676:
URL: https://github.com/apache/iceberg/pull/3676#discussion_r826178425
##########
File path:
core/src/test/java/org/apache/iceberg/actions/TestBinPackStrategy.java
##########
@@ -138,6 +138,38 @@ public void testGroupingMinInputFilesInvalid() {
0, Iterables.size(grouped));
}
+ @Test
+ public void testGroupingMinInputFilesAsOne() {
+ RewriteStrategy strategy = defaultBinPack().options(ImmutableMap.of(
+ BinPackStrategy.MIN_INPUT_FILES, Integer.toString(1),
+ BinPackStrategy.MAX_FILE_SIZE_BYTES, Long.toString(3 * MB),
+ RewriteDataFiles.TARGET_FILE_SIZE_BYTES, Long.toString(2 * MB),
+ BinPackStrategy.MIN_FILE_SIZE_BYTES, Long.toString(MB),
+ BinPackStrategy.DELETE_FILE_THRESHOLD, Integer.toString(2)
+ ));
+
+ // single file within a group, with size within threshold and no deletes
should be considered as NOOP.
+ Iterable<FileScanTask> testFiles1 = filesOfSize(1);
+ Iterable<List<FileScanTask>> grouped1 =
strategy.planFileGroups(testFiles1);
+
+ Assert.assertEquals("Should plan 0 group, as 1 minInputFile with size
within threshold and no deletes should be " +
+ "treated as NOOP",
+ 0, Iterables.size(grouped1));
+
+ // single file with size > targetSize should be planed
+ Iterable<FileScanTask> testFiles2 = filesOfSize(4 * MB);
+ Iterable<List<FileScanTask>> grouped2 =
strategy.planFileGroups(testFiles2);
+
+ Assert.assertEquals("Should plan 1 group", 1, Iterables.size(grouped2));
+
+ // single file with a delete should be planned, even when
deletedFileThreshold is 2
Review comment:
was trying to handle this :
> A group with a single file that is modified by deletes should be rewritten
(if the rewrite deletes filter is on)
here in previous scenario if minInputFiles was 1, even it didn't pass the
deleteFileThreshold we would have planned it, I thought by the line above if
there are groups with 1 file effected by deletes we should attempt to re-write
it..
Apologies, Am I missing something here ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
