singhpk234 commented on a change in pull request #3676:
URL: https://github.com/apache/iceberg/pull/3676#discussion_r826302669
##########
File path:
core/src/test/java/org/apache/iceberg/actions/TestBinPackStrategy.java
##########
@@ -187,10 +212,10 @@ public void testGroupingWithDeletes() {
@Test
public void testMaxGroupSize() {
RewriteStrategy strategy = defaultBinPack().options(ImmutableMap.of(
- RewriteDataFiles.MAX_FILE_GROUP_SIZE_BYTES, Long.toString(1000 * MB)
+ RewriteDataFiles.MAX_FILE_GROUP_SIZE_BYTES, Long.toString(1300 * MB)
Review comment:
when I updated the sizeOfInputFiles to be > `maxFileSize`, it started
breaking as default value is 1.8 * (default value of targetFileSize) which
makes maxFileSize now to be `921.6 MB`.
We were planning 2 groups with 900 MB sizeOfInputFiles size which now
started to fail.. hence made groups of 1200 MB now to restore the assertions of
`testMaxGroupSize`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
