kbendick commented on a change in pull request #4325:
URL: https://github.com/apache/iceberg/pull/4325#discussion_r826330353
##########
File path: data/src/main/java/org/apache/iceberg/data/TableMigrationUtil.java
##########
@@ -97,8 +102,10 @@ private TableMigrationUtil() {
.collect(Collectors.toList());
DataFile[] datafiles = new DataFile[fileStatus.size()];
Tasks.Builder<Integer> task = Tasks.range(fileStatus.size())
- .stopOnFailure()
- .throwFailureWhenFinished();
+ .throwFailureWhenFinished(!skipCorruptFiles);
+ if (!skipCorruptFiles) {
+ task.stopOnFailure();
Review comment:
Nit: Instead of updating the `throwFailureWhenFinished` and then having
this `if` statement, it might be cleaner to simply place the
`throwFailureWhenFinished` inside of the if statement as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
