hililiwei commented on a change in pull request #4325:
URL: https://github.com/apache/iceberg/pull/4325#discussion_r834935638
##########
File path: data/src/main/java/org/apache/iceberg/data/TableMigrationUtil.java
##########
@@ -121,9 +156,13 @@ private TableMigrationUtil() {
datafiles[index] = buildDataFile(fileStatus.get(index),
partitionKey, spec, metrics, "orc");
});
} else {
- throw new UnsupportedOperationException("Unknown partition format: " +
format);
+ if (skipCorruptFiles) {
+ LOG.warn("Unknown partition format: {}", format);
Review comment:
It is not within the `Task`, suppression exception does not take effect
here.
##########
File path: data/src/main/java/org/apache/iceberg/data/TableMigrationUtil.java
##########
@@ -140,7 +179,7 @@ private static Metrics getAvroMerics(Path path,
Configuration conf) {
return new Metrics(rowCount, null, null, null, null);
} catch (UncheckedIOException e) {
throw new RuntimeException("Unable to read Avro file: " +
- path, e);
Review comment:
updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
