kbendick commented on pull request #4326:
URL: https://github.com/apache/iceberg/pull/4326#issuecomment-1067276090


   > Okay, so we just need to tag `release-base-0.13.0` and the main branch 
should start building as `0.14.0-SNAPSHOT` then?
   
   Yes I believe so. The 
[plugin](https://github.com/palantir/gradle-git-version) adds a gradle task 
`printVersion`.
   
   I ran `./gradlew printVersion` and got `release-base-0.12.0`.
   
   This is equivalent to `git describe --tags --always --first-parent`, though 
we pass in the `release-base-` so it filters on that.
   
   To test your idea, I tried tagging locally.
   
   ```
   ➜   ./gradlew printVersion
   
   > Task :printVersion
   0.13.0-SNAPSHOT
   
   ➜  git describe --tags --always --first-parent
   release-base-0.12.0-646-g7f07ed451
   
   ➜  git tag release-base-0.13.0
   ➜  git describe --tags --always --first-parent
   release-base-0.13.0
   ➜  ./gradlew printVersion
   
   > Task :printVersion
   0.14.0-SNAPSHOT
   ```
   
   So if we wanted to publish a snapshot using the next minor version number 
(14 in this case), and ignore the fact that we might ship a patch now and then, 
what you suggested would be correct @rdblue.
   
   If we wanted to take into account the patch, we could match on it. But 
presently we're more or less always working towards the next minor version, and 
then occasionally releasing a patch that is cherry-picked. But the build 
against `master` represents the build for the next minor version.
   
   **TLDR** - tagging `release-base-0.13.0` will start building as 
`0.14.0-SNAPSHOT`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to