ajantha-bhat edited a comment on pull request #4326: URL: https://github.com/apache/iceberg/pull/4326#issuecomment-1067476142
> Alternatively, we can update the gitVersion prefix to be apache-iceberg-, which would get us the same results without having to push an additional tag (just the normal release tag). @kbendick: I already tried this before raising the PR. This doesn't work, `gitVersion` needs an annotated tag on the `master` branch. The last annotated tag on `master` we had is on 0.12.0. The tags created after 0.12.0 is not an annotated tag. `git log --oneline --decorate=short | grep 'tag\:' | head -n3` <img width="1058" alt="Screenshot 2022-03-14 at 10 58 15 PM" src="https://user-images.githubusercontent.com/5889404/158288696-e1602628-bdf3-408d-b109-915107b28e9a.png";> **So, I think new release tags are created from release branch instead of master.** Also we may not able to create tags from the `master` branch as commits are not same as release branch. Tag should match release SHA ? Considering all this I went with `version.txt` @rdblue: What is the problem with `version.txt` ?, we can still update it after every release on master branch? Can you elaborate the problem ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/5889404/158288696-e1602628-bdf3-408d-b109-915107b28e9a.png"](https://user-images.githubusercontent.com/5889404/158288696-e1602628-bdf3-408d-b109-915107b28e9a.png"){kind=link}