singhpk234 commented on a change in pull request #4248:
URL: https://github.com/apache/iceberg/pull/4248#discussion_r829394790
##########
File path:
aws/src/integration/java/org/apache/iceberg/aws/glue/TestGlueCatalogTable.java
##########
@@ -74,6 +74,8 @@ public void testCreateTable() {
Assert.assertTrue(response.table().parameters().containsKey(BaseMetastoreTableOperations.METADATA_LOCATION_PROP));
Assert.assertEquals(schema.columns().size(),
response.table().storageDescriptor().columns().size());
Assert.assertEquals(partitionSpec.fields().size(),
response.table().partitionKeys().size());
+ Assert.assertEquals("additionalLocations should match",
tableLocationProperties.values(),
Review comment:
yes I checked running the test case against master right now it passes :
```shell
pk/iceberg - (master) > ./gradlew :iceberg-aws:integrationTest --tests
"org.apache.iceberg.aws.glue.TestGlueCatalogTable"
BUILD SUCCESSFUL in 1m 44s
14 actionable tasks: 1 executed, 13 up-to-date
```
Looks like the order is of the output is messed up are you testing this in
your branch ? if yes some change might have caused the diff in order of keys of
HashMap.
##########
File path:
aws/src/integration/java/org/apache/iceberg/aws/glue/TestGlueCatalogTable.java
##########
@@ -74,6 +74,8 @@ public void testCreateTable() {
Assert.assertTrue(response.table().parameters().containsKey(BaseMetastoreTableOperations.METADATA_LOCATION_PROP));
Assert.assertEquals(schema.columns().size(),
response.table().storageDescriptor().columns().size());
Assert.assertEquals(partitionSpec.fields().size(),
response.table().partitionKeys().size());
+ Assert.assertEquals("additionalLocations should match",
tableLocationProperties.values(),
Review comment:
This is very strange, if possible can you please share the java version
you are in.
P.S thankyou for making the change to fix it, have added a feedback, do let
me know what you think of it,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
