xiaoxuandev commented on a change in pull request #4248:
URL: https://github.com/apache/iceberg/pull/4248#discussion_r829380910
##########
File path:
aws/src/integration/java/org/apache/iceberg/aws/glue/TestGlueCatalogTable.java
##########
@@ -74,6 +74,8 @@ public void testCreateTable() {
Assert.assertTrue(response.table().parameters().containsKey(BaseMetastoreTableOperations.METADATA_LOCATION_PROP));
Assert.assertEquals(schema.columns().size(),
response.table().storageDescriptor().columns().size());
Assert.assertEquals(partitionSpec.fields().size(),
response.table().partitionKeys().size());
+ Assert.assertEquals("additionalLocations should match",
tableLocationProperties.values(),
Review comment:
Is this test passing? it fails on my side with:
Expected :[s3://xioxuan-test/writeDataLoc,
s3://xioxuan-test/writeMetaDataLoc, s3://xioxuan-test/writeFolderStorageLoc]
Actual :[s3://xioxuan-test/writeMetaDataLoc,
s3://xioxuan-test/writeDataLoc, s3://xioxuan-test/writeFolderStorageLoc]
##########
File path:
aws/src/integration/java/org/apache/iceberg/aws/glue/TestGlueCatalogTable.java
##########
@@ -74,6 +74,8 @@ public void testCreateTable() {
Assert.assertTrue(response.table().parameters().containsKey(BaseMetastoreTableOperations.METADATA_LOCATION_PROP));
Assert.assertEquals(schema.columns().size(),
response.table().storageDescriptor().columns().size());
Assert.assertEquals(partitionSpec.fields().size(),
response.table().partitionKeys().size());
+ Assert.assertEquals("additionalLocations should match",
tableLocationProperties.values(),
Review comment:
https://github.com/apache/iceberg/pull/4355
##########
File path:
aws/src/integration/java/org/apache/iceberg/aws/glue/TestGlueCatalogTable.java
##########
@@ -74,6 +74,8 @@ public void testCreateTable() {
Assert.assertTrue(response.table().parameters().containsKey(BaseMetastoreTableOperations.METADATA_LOCATION_PROP));
Assert.assertEquals(schema.columns().size(),
response.table().storageDescriptor().columns().size());
Assert.assertEquals(partitionSpec.fields().size(),
response.table().partitionKeys().size());
+ Assert.assertEquals("additionalLocations should match",
tableLocationProperties.values(),
Review comment:
Yes. I am testing is against master branch. Let me double check again.
##########
File path:
aws/src/integration/java/org/apache/iceberg/aws/glue/TestGlueCatalogTable.java
##########
@@ -74,6 +74,8 @@ public void testCreateTable() {
Assert.assertTrue(response.table().parameters().containsKey(BaseMetastoreTableOperations.METADATA_LOCATION_PROP));
Assert.assertEquals(schema.columns().size(),
response.table().storageDescriptor().columns().size());
Assert.assertEquals(partitionSpec.fields().size(),
response.table().partitionKeys().size());
+ Assert.assertEquals("additionalLocations should match",
tableLocationProperties.values(),
Review comment:
Yes. I am testing is against master branch. Let me double check.
##########
File path:
aws/src/integration/java/org/apache/iceberg/aws/glue/TestGlueCatalogTable.java
##########
@@ -74,6 +74,8 @@ public void testCreateTable() {
Assert.assertTrue(response.table().parameters().containsKey(BaseMetastoreTableOperations.METADATA_LOCATION_PROP));
Assert.assertEquals(schema.columns().size(),
response.table().storageDescriptor().columns().size());
Assert.assertEquals(partitionSpec.fields().size(),
response.table().partitionKeys().size());
+ Assert.assertEquals("additionalLocations should match",
tableLocationProperties.values(),
Review comment:
it is still failing when I run clean build on master branch. I added
this fix and it works. https://github.com/apache/iceberg/pull/4355
##########
File path:
aws/src/integration/java/org/apache/iceberg/aws/glue/TestGlueCatalogTable.java
##########
@@ -74,6 +74,8 @@ public void testCreateTable() {
Assert.assertTrue(response.table().parameters().containsKey(BaseMetastoreTableOperations.METADATA_LOCATION_PROP));
Assert.assertEquals(schema.columns().size(),
response.table().storageDescriptor().columns().size());
Assert.assertEquals(partitionSpec.fields().size(),
response.table().partitionKeys().size());
+ Assert.assertEquals("additionalLocations should match",
tableLocationProperties.values(),
Review comment:
openjdk version "1.8.0_322"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
