jackye1995 commented on a change in pull request #4334:
URL: https://github.com/apache/iceberg/pull/4334#discussion_r830163316
##########
File path: aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java
##########
@@ -170,6 +171,17 @@
*/
public static final String S3FILEIO_SESSION_TOKEN = "s3.session-token";
+ /**
+ * Enable to make S3FileIO, to make cross-region call to the region
specified in the ARN.
+ * <p>
+ * When set, the client can make a cross-region call to the region specified
in the ARN,
+ * otherwise an exception will be thrown if cross-region call is tried.
+ *
+ * For more details see :
https://github.com/aws/aws-sdk-java-v2/blob/master/services/s3/src/main/java/software/amazon/awssdk/services/s3/S3Configuration.java#L186
+ */
+ public static final String S3_ARN_REGION_ENABLED = "s3.arn-region-enabled";
Review comment:
Sorry I just notice the name in S3Configuration is
`useArnRegionEnabled`, I think we should map the name exactly to the s3 to call
it `s3.use-arn-region-enabled`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
