jackye1995 commented on a change in pull request #4334:
URL: https://github.com/apache/iceberg/pull/4334#discussion_r829703375
##########
File path:
aws/src/integration/java/org/apache/iceberg/aws/s3/TestS3FileIOIntegration.java
##########
@@ -268,4 +306,11 @@ private void validateRead(S3FileIO s3FileIO) throws
Exception {
stream.close();
Assert.assertEquals(content, result);
}
+
+ private String testAccessPointARN() {
Review comment:
For boolean config, prefer to use `-enabled` suffix as convention. All
S3 features should be under `s3.` config namespace.
I think we can just follow the S3 variable name, `s3.arn-region-enabled`
since S3 already gave this feature this name. We can directly link to this
feature's github link in AWS SDK v2 repo as a reference. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
