jackye1995 commented on pull request #4342: URL: https://github.com/apache/iceberg/pull/4342#issuecomment-1073367370
> I can also imagine a situations where client-side deletes aren't allowed and the warehouse relies on an orphan files service. That means all of the combinations of "skip delete" and "tag before delete" are valid use cases, so we should separate those. Yes totally agree. However, should it be `s3.delete-enabled`, or a broader `io.delete-enabled` feature? If a client-side delete is not allowed, it should be applied to all the FileIOs instead of just S3. I thought about the 4 possible combinations, and I did not ask for an additional `-enabled` flag because: 1. delete enabled + tags set: this case does not really exist, because once the object is deleted in S3 there is no tag anymore. 2. delete disabled + tags set: this is the feature in the PR 3. delete enabled + no tag: this is the existing behavior 4. delete disabled + no tag: this is the case we agree that an orphan file service would take care of everything, and goes back to my question of should this be a feature flag across all FileIOs? If so we can publish a follow-up PR for that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
