jackye1995 commented on a change in pull request #4342:
URL: https://github.com/apache/iceberg/pull/4342#discussion_r831488382
##########
File path: aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java
##########
@@ -254,6 +254,30 @@
*/
public static final String S3_WRITE_TAGS_PREFIX = "s3.write.tags.";
+ /**
+ * Used by {@link S3FileIO} to tag objects when deleting. When this config
is set, objects are
+ * tagged with the configured key-value pairs instead of being hard-deleted.
This is considered a
+ * soft-delete, because users are able to configure tag-based object
lifecycle policy at bucket
+ * level to transition objects to different tiers.
+ * <p>
+ * For more details, see
https://docs.aws.amazon.com/AmazonS3/latest/userguide/object-lifecycle-mgmt.html
+ * <p>
+ * Example: s3.delete.tags.my_key=my_val
+ */
+ public static final String S3_DELETE_TAGS_PREFIX = "s3.delete.tags.";
+
+ /**
+ * Number of threads to use for adding delete tags to S3 objects, default to
{@link
+ * Runtime#availableProcessors()}
+ */
+ public static final String S3FILEIO_DELETE_TAGS_THREADS =
"s3.delete.tags.num-threads";
+
+ /**
+ * Used by {@link S3FileIO} to delete files.
Review comment:
The description here is not accurate, should say something like
"Determines if S3FileIO delete the object when io.delete() is called, default
to true. Once disabled, users are expected to set tags through
S3_DELETE_TAGS_PREFIX and manage deleted files through S3 lifecycle policy"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
