openinx commented on a change in pull request #3784: URL: https://github.com/apache/iceberg/pull/3784#discussion_r832800368
########## File path: orc/src/main/java/org/apache/iceberg/orc/EstimateOrcAveWidthVisitor.java ########## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.orc; + +import java.util.List; +import java.util.Optional; +import org.apache.orc.TypeDescription; + +public class EstimateOrcAveWidthVisitor extends OrcSchemaVisitor<Integer> { Review comment: Nit: `Ave` -> `Avg` ? ########## File path: orc/src/main/java/org/apache/iceberg/orc/EstimateOrcAveWidthVisitor.java ########## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.orc; + +import java.util.List; +import java.util.Optional; +import org.apache.orc.TypeDescription; + +public class EstimateOrcAveWidthVisitor extends OrcSchemaVisitor<Integer> { + + @Override + public Integer record(TypeDescription record, List<String> names, List<Integer> fields) { + return fields.stream().reduce(Integer::sum).orElse(0); + } + + @Override + public Integer list(TypeDescription array, Integer elementResult) { Review comment: Nit: How about rename it to `elementWidth` ? ########## File path: orc/src/main/java/org/apache/iceberg/orc/OrcFileAppender.java ########## @@ -66,6 +71,11 @@ this.metricsConfig = metricsConfig; TypeDescription orcSchema = ORCSchemaUtil.convert(schema); + + List<Integer> integers = OrcSchemaVisitor.visitSchema(orcSchema, new EstimateOrcAveWidthVisitor()); Review comment: integers ? That's a wired name... I will suggest to use `fieldWidths` ########## File path: orc/src/main/java/org/apache/iceberg/orc/OrcFileAppender.java ########## @@ -66,6 +71,11 @@ this.metricsConfig = metricsConfig; TypeDescription orcSchema = ORCSchemaUtil.convert(schema); + + List<Integer> integers = OrcSchemaVisitor.visitSchema(orcSchema, new EstimateOrcAveWidthVisitor()); + estimateLength = integers + .stream().reduce(Integer::sum).orElse(1); Review comment: orElse(0) ? If there is no field in this orc schema, its estimate length should be 0 , right ? ########## File path: orc/src/main/java/org/apache/iceberg/orc/EstimateOrcAveWidthVisitor.java ########## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.orc; + +import java.util.List; +import java.util.Optional; +import org.apache.orc.TypeDescription; + +public class EstimateOrcAveWidthVisitor extends OrcSchemaVisitor<Integer> { + + @Override + public Integer record(TypeDescription record, List<String> names, List<Integer> fields) { + return fields.stream().reduce(Integer::sum).orElse(0); + } + + @Override + public Integer list(TypeDescription array, Integer elementResult) { + return elementResult; + } + + @Override + public Integer map(TypeDescription map, Integer keyWidth, Integer valueWidth) { + return keyWidth + valueWidth; + } + + @Override + public Integer primitive(TypeDescription primitive) { + Optional<Integer> icebergIdOpt = ORCSchemaUtil.icebergID(primitive); + + if (!icebergIdOpt.isPresent()) { + return 0; + } + + switch (primitive.getCategory()) { Review comment: I think we need to align with the approach to estimate the avg width for each data type. I think the basic rule is: we need to read the GenericOrcWriters to see how those data types are encouded into the ORC column vector. That is the occupied in-memory byte size without any columnar compression. ########## File path: orc/src/main/java/org/apache/iceberg/orc/OrcFileAppender.java ########## @@ -66,6 +71,11 @@ this.metricsConfig = metricsConfig; TypeDescription orcSchema = ORCSchemaUtil.convert(schema); + + List<Integer> integers = OrcSchemaVisitor.visitSchema(orcSchema, new EstimateOrcAveWidthVisitor()); + estimateLength = integers Review comment: Pls use `this.estimateWidth` to assign a value to the private class member ? ########## File path: orc/src/main/java/org/apache/iceberg/orc/EstimateOrcAveWidthVisitor.java ########## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.orc; + +import java.util.List; +import java.util.Optional; +import org.apache.orc.TypeDescription; + +public class EstimateOrcAveWidthVisitor extends OrcSchemaVisitor<Integer> { + + @Override + public Integer record(TypeDescription record, List<String> names, List<Integer> fields) { + return fields.stream().reduce(Integer::sum).orElse(0); + } + + @Override + public Integer list(TypeDescription array, Integer elementResult) { + return elementResult; + } + + @Override + public Integer map(TypeDescription map, Integer keyWidth, Integer valueWidth) { + return keyWidth + valueWidth; + } + + @Override + public Integer primitive(TypeDescription primitive) { + Optional<Integer> icebergIdOpt = ORCSchemaUtil.icebergID(primitive); + + if (!icebergIdOpt.isPresent()) { + return 0; + } + + switch (primitive.getCategory()) { + case BOOLEAN: + case BYTE: + case CHAR: + return 1; + case SHORT: + return 2; + case INT: + case FLOAT: + return 4; + case LONG: + case DOUBLE: + return 8; + case DATE: + case TIMESTAMP: + case TIMESTAMP_INSTANT: + return 12; + case STRING: + case VARCHAR: + case BINARY: + return 128; + case DECIMAL: + return primitive.getPrecision() * 4 + 1; Review comment: You mean each digit from the unscaled value will occupied 4 byte ? In my view, each digit will be range from 0~9, then one byte is enough. ########## File path: orc/src/main/java/org/apache/iceberg/orc/EstimateOrcAveWidthVisitor.java ########## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.orc; + +import java.util.List; +import java.util.Optional; +import org.apache.orc.TypeDescription; + +public class EstimateOrcAveWidthVisitor extends OrcSchemaVisitor<Integer> { + + @Override + public Integer record(TypeDescription record, List<String> names, List<Integer> fields) { + return fields.stream().reduce(Integer::sum).orElse(0); + } + + @Override + public Integer list(TypeDescription array, Integer elementResult) { + return elementResult; + } + + @Override + public Integer map(TypeDescription map, Integer keyWidth, Integer valueWidth) { + return keyWidth + valueWidth; + } + + @Override + public Integer primitive(TypeDescription primitive) { + Optional<Integer> icebergIdOpt = ORCSchemaUtil.icebergID(primitive); + + if (!icebergIdOpt.isPresent()) { + return 0; + } + + switch (primitive.getCategory()) { + case BOOLEAN: + case BYTE: + case CHAR: + return 1; + case SHORT: + return 2; + case INT: + case FLOAT: + return 4; + case LONG: + case DOUBLE: + return 8; + case DATE: Review comment: According to the above rule, the `DATE` will be encoded as a long type, then I think its width should be 8 bytes. https://github.com/apache/iceberg/blob/b16c0a4f16236474e35869e21d1a303a113ac6e1/orc/src/main/java/org/apache/iceberg/data/orc/GenericOrcWriters.java#L313 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
