RussellSpitzer commented on a change in pull request #4377:
URL: https://github.com/apache/iceberg/pull/4377#discussion_r833202471
##########
File path: core/src/main/java/org/apache/iceberg/actions/RewriteFileGroup.java
##########
@@ -77,4 +78,9 @@ public String toString() {
.add("numAddedFiles", addedFiles == null ? "Rewrite Incomplete" :
Integer.toString(addedFiles.size()))
.toString();
}
+
+ @Override
+ public int compareTo(@Nonnull final RewriteFileGroup o) {
Review comment:
this doesn't seem like it is required and i'm a bit dubious about having
all rewriteFileGroups treated as equal. The Comparator approach below seems
like the right thing to do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
