RussellSpitzer commented on a change in pull request #4377:
URL: https://github.com/apache/iceberg/pull/4377#discussion_r833205700



##########
File path: 
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/actions/BaseRewriteDataFilesSparkAction.java
##########
@@ -339,19 +342,25 @@ private Result 
doExecuteWithPartialProgress(RewriteExecutionContext ctx, Stream<
 
   private Stream<RewriteFileGroup> toGroupStream(RewriteExecutionContext ctx,
                                                  Map<StructLike, 
List<List<FileScanTask>>> fileGroupsByPartition) {
+    PriorityQueue<RewriteFileGroup> rewriteFileGroups = new 
PriorityQueue<>(comparator());

Review comment:
       Why this over say,
   
    Stream.sorted(comparator())?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to