rdblue commented on a change in pull request #4071:
URL: https://github.com/apache/iceberg/pull/4071#discussion_r835971634
##########
File path: core/src/main/java/org/apache/iceberg/MetadataUpdate.java
##########
@@ -230,24 +230,28 @@ public void applyTo(TableMetadata.Builder
metadataBuilder) {
class SetSnapshotRef implements MetadataUpdate {
private final String name;
- private final long snapshotId;
+ private final SnapshotRef ref;
Review comment:
The [`SetSnapshotRef`
update](https://github.com/apache/iceberg/blob/master/open-api/rest-catalog-open-api.yaml#L1233-L1242)
in the REST spec has all of the fields here, rather than holding a
`SnapshotRef` object.
To make this serialize like the spec, this should have `type`,
`maxRefAgeMs`, `maxSnapshotAgeMs`, and `minSnapshotsToKeep` fields.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
