rdblue commented on a change in pull request #4393:
URL: https://github.com/apache/iceberg/pull/4393#discussion_r835980861



##########
File path: aliyun/src/main/java/org/apache/iceberg/aliyun/oss/OSSInputFile.java
##########
@@ -24,17 +24,18 @@
 import org.apache.iceberg.exceptions.ValidationException;
 import org.apache.iceberg.io.InputFile;
 import org.apache.iceberg.io.SeekableInputStream;
+import org.apache.iceberg.metrics.MetricsContext;
 
-public class OSSInputFile extends BaseOSSFile implements InputFile {
+class OSSInputFile extends BaseOSSFile implements InputFile {

Review comment:
       This is technically a breaking change. I think we should roll it back in 
case anyone references this file. We can deprecate the class so that we can 
make this change in a release or two.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to