rdblue commented on a change in pull request #4393:
URL: https://github.com/apache/iceberg/pull/4393#discussion_r835980956
##########
File path:
aliyun/src/main/java/org/apache/iceberg/aliyun/oss/OSSInputStream.java
##########
@@ -44,10 +48,16 @@
private long next = 0;
private boolean closed = false;
- public OSSInputStream(OSS client, OSSURI uri) {
+ private final Counter<Long> readBytes;
+ private final Counter<Integer> readOperations;
+
+ public OSSInputStream(OSS client, OSSURI uri, MetricsContext metrics) {
Review comment:
Since the old constructor was public, should we keep it and pass
`nullMetrics`?
##########
File path: aliyun/src/main/java/org/apache/iceberg/aliyun/oss/OSSOutputFile.java
##########
@@ -25,15 +25,17 @@
import org.apache.iceberg.io.InputFile;
import org.apache.iceberg.io.OutputFile;
import org.apache.iceberg.io.PositionOutputStream;
+import org.apache.iceberg.metrics.MetricsContext;
class OSSOutputFile extends BaseOSSFile implements OutputFile {
- OSSOutputFile(OSS client, OSSURI uri, AliyunProperties aliyunProperties) {
- super(client, uri, aliyunProperties);
+ OSSOutputFile(OSS client, OSSURI uri, AliyunProperties aliyunProperties,
MetricsContext metrics) {
Review comment:
Similar here. Should we keep the old constructor and pass `nullMetrics`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
