danielcweeks commented on pull request #4342: URL: https://github.com/apache/iceberg/pull/4342#issuecomment-1082103071
@rajarshisarkar and @jackye1995 One small comment about proper shutdown above, but other than that I'm generally ok with this. I think we can tackle refactoring some of this logic later (the S3FileIO is now mostly bulk/delete/tagging, so I think there's an opportunity to clean this up). It is important to note that for the bulk use cases, tagging will be quite a bit slower since we have to tag each object individually. That may not scale particularly well, but at least the option to tag is there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
