jackye1995 commented on a change in pull request #4342:
URL: https://github.com/apache/iceberg/pull/4342#discussion_r838133144
##########
File path: aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java
##########
@@ -184,6 +245,19 @@ private S3Client client() {
return client;
}
+ private ExecutorService executorService() {
Review comment:
I think we cannot close it, because it's a static variable and shared
across FileIOs? Which is similar to the one in `S3OutputStream`. We either not
close it, or make it an instance variable instead. I think not closing it is
fine given we are already doing that in S3OutputStream, any thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
