RussellSpitzer commented on a change in pull request #4433:
URL: https://github.com/apache/iceberg/pull/4433#discussion_r838728184
##########
File path: core/src/main/java/org/apache/iceberg/actions/SortStrategy.java
##########
@@ -48,14 +48,6 @@
public abstract class SortStrategy extends BinPackStrategy {
private static final Logger LOG =
LoggerFactory.getLogger(SortStrategy.class);
- /**
- * Rewrites all files, regardless of their size. Defaults to false,
rewriting only mis-sized
- * files;
- */
- public static final String REWRITE_ALL = "rewrite-all";
- public static final boolean REWRITE_ALL_DEFAULT = false;
-
-
private static final Set<String> validOptions = ImmutableSet.of(
REWRITE_ALL
);
Review comment:
I agree we should probably just expose rewrite all as a protected method
and let the sub class use the value set in the parent (binpackstrat)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
