RussellSpitzer commented on a change in pull request #4433:
URL: https://github.com/apache/iceberg/pull/4433#discussion_r839653952
##########
File path: core/src/main/java/org/apache/iceberg/actions/SortStrategy.java
##########
@@ -108,22 +84,12 @@ public RewriteStrategy options(Map<String, String>
options) {
@Override
public Iterable<FileScanTask> selectFilesToRewrite(Iterable<FileScanTask>
dataFiles) {
- if (rewriteAll) {
- LOG.info("Sort Strategy for table {} set to rewrite all data files",
table().name());
- return dataFiles;
- } else {
- return super.selectFilesToRewrite(dataFiles);
- }
+ return super.selectFilesToRewrite(dataFiles);
}
@Override
public Iterable<List<FileScanTask>> planFileGroups(Iterable<FileScanTask>
dataFiles) {
Review comment:
This is also not needed if we are only calling the super method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
