rdblue commented on a change in pull request #4263: URL: https://github.com/apache/iceberg/pull/4263#discussion_r839057111
########## File path: python/src/iceberg/conversions.py ########## @@ -0,0 +1,318 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""Utility module for various conversions around PrimitiveType implementations + +This module enables: + - Converting partition strings to built-in python objects + - Converting a value to a byte buffer + - Converting a byte buffer to a value + +Note: + Conversion logic varies based on the PrimitiveType implementation. Therefore conversion functions + are defined here as generic functions using the @singledispatch decorator. For each PrimitiveType + implementation, a concrete function is registered for each generic conversion function. For PrimitiveType + implementations that share the same conversion logic, registrations can be stacked. +""" +import struct +import uuid +from decimal import Decimal +from functools import singledispatch +from typing import Union + +from iceberg.types import ( + BinaryType, + BooleanType, + DateType, + DecimalType, + DoubleType, + FixedType, + FloatType, + IntegerType, + LongType, + PrimitiveType, + StringType, + TimestampType, + TimestamptzType, + TimeType, + UUIDType, +) + + +def handle_none(func): + """A decorator function to handle cases where partition values are `None` or "__HIVE_DEFAULT_PARTITION__" + + Args: + func (Callable): A function registered to the singledispatch function `partition_to_py` + """ + + def wrapper(primitive_type, value_str): + if value_str is None: + return None + elif value_str == "__HIVE_DEFAULT_PARTITION__": + return None + return func(primitive_type, value_str) + + return wrapper + + +def decimal_to_unscaled(value: Decimal) -> int: + """Get an unscaled value given a Decimal value + + Args: + value (Decimal): A Decimal instance + + Returns: + int: The unscaled value + """ + return int(value.to_integral_value()) Review comment: This isn't correct. `to_integral_value` doesn't result in the unscaled value, it results in the value rounded to 0 decimal places. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
