rdblue edited a comment on pull request #4454: URL: https://github.com/apache/iceberg/pull/4454#issuecomment-1084983597
This looks good to me. It may be simpler just to eagerly create the S3 client. For @samarthjain's concern, I think it is okay. `initialize` is called just after creating the `FileIO` instance before it is shared across threads. > Should a FileIO object be shareable between multiple threads? Yes, we do assume that these are shared. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
